Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unneeded test aliases #589

Merged
merged 3 commits into from Jan 25, 2022
Merged

Conversation

paarthmadan
Copy link
Contributor

This is following a TODO added in c6d95da, to remove aliases and use Minitest when it's available. These should be 馃憤 now given the version of Rails, Ruby and Minitest we support.

3 changes:

  1. Remove alias for assert_raise (use: assert_raises)
  2. Remove alias for assert_not_equal) (use: refute_equal)
  3. Remove conditional usage of Minitest::Unit::TestCase (always use Minitest::Test)

Copy link
Collaborator

@radar radar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@radar radar merged commit ade765a into ruby-i18n:master Jan 25, 2022
@paarthmadan paarthmadan deleted the pm/test-debt branch February 18, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants